FIX: DeLoRA adapter deletion issue #2853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, adapter deletion raises an error with DeLoRA. The reason is that the dropout module is called module_dropout, i.e. the prefix "delora" is not part of the name, which is required for proper working. This PR renames the attribute to delora_dropout. The reason why this was not caught is because the corresponding test was not updated to include DeLoRA. The test was thus also changed. Note: I came across this issue in huggingface#2846 but I wanted to fix it in a separate PR, as huggingface#2846 is probably not going to make it into the next PEFT release.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
FYI @mwbini |
|
Thanks for fixing these. I also noticed the methods constraints in |
githubnemo
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adapter deletion raises an error with DeLoRA. The reason is that the dropout module is called
module_dropout, i.e. the prefix"delora"is not part of the name, which is required for proper working. This PR renames the attribute todelora_dropout.The reason why this was not caught is because the corresponding test was not updated to include DeLoRA. The test was thus also changed.
I also noticed that the error message for save merging is different from other PEFT methods. In general, that would be okay, but it means we would have to add a special case for unit testing this, so I consolidated the error message.
Note: I came across these issues in #2846 but I wanted to fix it in a separate PR, as #2846 is probably not going to make it into the next PEFT release.